<html>
<head><meta charset="utf-8"><title>Proposal: New Rustc Guide Diagrams · t-compiler/wg-rustc-dev-guide · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/index.html">t-compiler/wg-rustc-dev-guide</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html">Proposal: New Rustc Guide Diagrams</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="189448735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189448735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189448735">(Mar 01 2020 at 21:34)</a>:</h4>
<p>I am working on new <code>graphviz</code> diagrams for the Rustc Overview and pulled together a hackmd document for discussion about other areas of the Guide where we might support the text with additional visuals: <a href="https://hackmd.io/24S8FCKTS2mp8zVOdrDjww" target="_blank" title="https://hackmd.io/24S8FCKTS2mp8zVOdrDjww">https://hackmd.io/24S8FCKTS2mp8zVOdrDjww</a> </p>
<p>The graphviz sources and local build instructions are included.   You can also render / explore in real time right in hackmd or on <a href="https://sketchviz.com" target="_blank" title="https://sketchviz.com">https://sketchviz.com</a>. </p>
<p>Please don't hesitate to edit the current examples, add new proposals, or recommend additions that might be helpful in this thread.</p>



<a name="189448976"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189448976" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189448976">(Mar 01 2020 at 21:42)</a>:</h4>
<p>I have recently tried to modify the method resolution part of the compiler, and was really confused, because I had no overall idea of how the system works, especially for diagnostics. So I think it deserves a schema</p>



<a name="189515697"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189515697" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189515697">(Mar 02 2020 at 17:41)</a>:</h4>
<p>agreed on everything :)</p>



<a name="189515764"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189515764" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189515764">(Mar 02 2020 at 17:42)</a>:</h4>
<p>the diagrams look great</p>



<a name="189515782"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189515782" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189515782">(Mar 02 2020 at 17:42)</a>:</h4>
<p>and yeah as <span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> says this deserves a schema</p>



<a name="189515934"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189515934" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189515934">(Mar 02 2020 at 17:44)</a>:</h4>
<p><span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> How do you suggest that we approach the work?  Edit in that document, reach consensus on how the diagram / visual should appear, then someone submit PR with it on the rustc-guide repo at which point we mark it as done in the hackmd document?</p>



<a name="189516206"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189516206" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189516206">(Mar 02 2020 at 17:47)</a>:</h4>
<p>yeah I would totally do that</p>



<a name="189516233"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189516233" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189516233">(Mar 02 2020 at 17:48)</a>:</h4>
<p>first reach consensus, edit the document and send a PR for wider reviews :)</p>



<a name="189516697"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189516697" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189516697">(Mar 02 2020 at 17:52)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> Want to add the schema that you recommended yesterday?</p>



<a name="189516743"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189516743" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189516743">(Mar 02 2020 at 17:53)</a>:</h4>
<p>I don't think I have enough knowledge on the topic for that</p>



<a name="189516890"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189516890" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189516890">(Mar 02 2020 at 17:54)</a>:</h4>
<p>But I wouldn't mind diving deeper into the code to finally find out</p>



<a name="189517124"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189517124" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189517124">(Mar 02 2020 at 17:56)</a>:</h4>
<p>Btw <span class="user-mention" data-user-id="262810">@Chris Simpkins</span> How did you plan to integrate the schemas to the book when they are ready? You will convert them to the SVG format, is this right? If so I think we should keep the source Graphviz graph somewhere on the repo to be able to easily edit them</p>



<a name="189517803"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189517803" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189517803">(Mar 02 2020 at 18:01)</a>:</h4>
<p><span class="user-mention silent" data-user-id="255061">LeSeulArtichaut</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-learning/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams/near/189517124" title="#narrow/stream/196385-t-compiler.2Fwg-learning/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams/near/189517124">said</a>:</p>
<blockquote>
<p>Btw <span class="user-mention silent" data-user-id="262810">Chris Simpkins</span> How did you plan to integrate the schemas to the book when they are ready? You will convert them to the SVG format, is this right? If so I think we should keep the source graph somewhere on the repo to be able to easily edit them</p>
</blockquote>
<p>Haven't planned that far ahead <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span>  But yes, that will be straightforward if <code>.DOT</code> sources are acceptable in repo.  The sources are currently linked in github gists on the hackmd document.  </p>
<p>Is there time to discuss this briefly as part of the WG-Learning meeting agenda this week <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> <span class="user-mention" data-user-id="198054">@mark-i-m</span> ?   If this seems like a good objective for one of our initial sprints, perhaps <span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> (if interested) and I can work out details and pitch them to you</p>



<a name="189518338"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189518338" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189518338">(Mar 02 2020 at 18:06)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> </p>
<blockquote>
<p>You will convert them to the SVG format, is this right?</p>
</blockquote>
<p>graphviz supports many formats (png, jpg, svg, pdf).  This is something that we should definitely discuss before the first PR on the repository.  I haven't looked through other image types to see what is currently used, file size impact / image quality, raster vs. vector...</p>



<a name="189532158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189532158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189532158">(Mar 02 2020 at 20:21)</a>:</h4>
<p>I see no reason to not accept <code>.dot</code> files in the repo. Those are text files, which do not carry much information (in the sense that it is Graphviz which converts them to an image), so they are very lightweight. <br>
For example, the <a href="https://hackmd.io/24S8FCKTS2mp8zVOdrDjww?both#Fig-212-NEW-DIAGRAM-Stages-of-the-Compile-Process" target="_blank" title="https://hackmd.io/24S8FCKTS2mp8zVOdrDjww?both#Fig-212-NEW-DIAGRAM-Stages-of-the-Compile-Process">Stages of the Compile Process diagram</a> is only 913 chars long, which is more then 7 times lighter than the <code>SUMMARY.md</code>.</p>



<a name="189532285"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189532285" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189532285">(Mar 02 2020 at 20:22)</a>:</h4>
<p>In fact, I think the question that stands now is, how do we convert the <code>.dot</code>s to exploitable images. Can we do it when building the book, for example? Would it be OK to add that dependency? etc...</p>



<a name="189534461"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189534461" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189534461">(Mar 02 2020 at 20:46)</a>:</h4>
<p><span class="user-mention silent" data-user-id="255061">LeSeulArtichaut</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-learning/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams/near/189532285" title="#narrow/stream/196385-t-compiler.2Fwg-learning/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams/near/189532285">said</a>:</p>
<blockquote>
<p>I see no reason to not accept .dot files in the repo. Those are text files, which do not carry much information (in the sense that it is Graphviz which converts them to an image), so they are very lightweight. <br>
For example, the Stages of the Compile Process diagram is only 913 chars long, which is more then 7 times lighter than the SUMMARY.md.</p>
<p>In fact, I think the question that stands now is, how do we convert the <code>.dot</code>s to exploitable images. Can we do it when building the book, for example? Would it be OK to add that dependency? etc...</p>
</blockquote>
<p>agree with all of these comments.</p>



<a name="189534888"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189534888" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189534888">(Mar 02 2020 at 20:50)</a>:</h4>
<p>we need to know who approves this</p>



<a name="189535032"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189535032" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189535032">(Mar 02 2020 at 20:52)</a>:</h4>
<p>I'll dive into some CI research and file size investigations</p>



<a name="189535128"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189535128" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189535128">(Mar 02 2020 at 20:53)</a>:</h4>
<p><del>I think that the rustc-guide is being manually built and pushed now?</del></p>



<a name="189535178"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189535178" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189535178">(Mar 02 2020 at 20:53)</a>:</h4>
<p>I haven't ever dived into those details actually <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="189535269"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189535269" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189535269">(Mar 02 2020 at 20:54)</a>:</h4>
<p>But as this is hosted on GitHub pages I think there is an automated process...?</p>



<a name="189535286"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189535286" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189535286">(Mar 02 2020 at 20:54)</a>:</h4>
<p>It looks like there is a Github Action <a href="https://github.com/rust-lang/rustc-guide/deployments" target="_blank" title="https://github.com/rust-lang/rustc-guide/deployments">https://github.com/rust-lang/rustc-guide/deployments</a></p>



<a name="189535407"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189535407" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189535407">(Mar 02 2020 at 20:55)</a>:</h4>
<p>Mhh, this is what I thought</p>



<a name="189536234"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189536234" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189536234">(Mar 02 2020 at 21:02)</a>:</h4>
<p>I don't see any static site build scripting though.  There is a CI dir with a shell script for line length linting in MD files</p>



<a name="189536300"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189536300" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189536300">(Mar 02 2020 at 21:03)</a>:</h4>
<p>The MD files are transformed into HTML/CSS by <code>mdbook</code></p>



<a name="189536521"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189536521" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189536521">(Mar 02 2020 at 21:05)</a>:</h4>
<p>(<a href="https://github.com/rust-lang/mdBook" target="_blank" title="https://github.com/rust-lang/mdBook">https://github.com/rust-lang/mdBook</a>)</p>



<a name="189536636"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189536636" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189536636">(Mar 02 2020 at 21:06)</a>:</h4>
<p>I wonder where the <code>mdbook</code> build workflow lives</p>



<a name="189536711"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189536711" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189536711">(Mar 02 2020 at 21:07)</a>:</h4>
<p>You could probably find an answer <a href="https://rust-lang.github.io/mdBook/" target="_blank" title="https://rust-lang.github.io/mdBook/">here</a></p>



<a name="189536773"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189536773" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189536773">(Mar 02 2020 at 21:08)</a>:</h4>
<p><em>I'm actually peeling the docs too</em> <span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span></p>



<a name="189536817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189536817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189536817">(Mar 02 2020 at 21:08)</a>:</h4>
<div class="codehilite"><pre><span></span>The build command is used to render your book:

mdbook build

It will try to parse your SUMMARY.md file to understand the structure of your book and fetch the corresponding files.

The rendered output will maintain the same directory structure as the source for convenience. Large books will therefore remain structured when rendered.
</pre></div>



<a name="189536864"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189536864" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189536864">(Mar 02 2020 at 21:09)</a>:</h4>
<p>Here are the docs on the <code>book.toml</code> config file: <a href="https://rust-lang.github.io/mdBook/format/config.html" target="_blank" title="https://rust-lang.github.io/mdBook/format/config.html">https://rust-lang.github.io/mdBook/format/config.html</a></p>



<a name="189536922"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189536922" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189536922">(Mar 02 2020 at 21:09)</a>:</h4>
<p>Idk if you can launch external processes though</p>



<a name="189536955"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189536955" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189536955">(Mar 02 2020 at 21:10)</a>:</h4>
<p>But I think that the image builds will live outside of the MD -&gt; html builds.  We would just need to point to the proper image file paths in the MD sources</p>



<a name="189537028"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189537028" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189537028">(Mar 02 2020 at 21:10)</a>:</h4>
<p>I think that's correct</p>



<a name="189537103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189537103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189537103">(Mar 02 2020 at 21:11)</a>:</h4>
<p>I'll do some local tests</p>



<a name="189537700"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189537700" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189537700">(Mar 02 2020 at 21:15)</a>:</h4>
<p>I think I have a plan in mind</p>



<a name="189537716"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189537716" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189537716">(Mar 02 2020 at 21:15)</a>:</h4>
<p>We already have <code>src/img</code></p>



<a name="189537888"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189537888" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189537888">(Mar 02 2020 at 21:17)</a>:</h4>
<p>So we basically have two options:<br>
1) We "compile" the <code>.dot</code>s manually on every change and store them here<br>
or<br>
2) We "compile" the <code>.dot</code>s on the CI build before running <code>mdbook</code> so we don't need to actually store them in the repo</p>



<a name="189537908"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189537908" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189537908">(Mar 02 2020 at 21:17)</a>:</h4>
<p><span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> Thoughts?</p>



<a name="189538316"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189538316" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189538316">(Mar 02 2020 at 21:22)</a>:</h4>
<p>Does rebuilding image files that don't need to be rebuilt because there were no changes in the images interfere with browser image caching?</p>



<a name="189538638"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189538638" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189538638">(Mar 02 2020 at 21:25)</a>:</h4>
<p>I guess <span class="user-mention" data-user-id="198054">@mark-i-m</span> or <span class="user-mention" data-user-id="116122">@simulacrum</span> may know better here</p>



<a name="189538720"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189538720" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189538720">(Mar 02 2020 at 21:26)</a>:</h4>
<p><span class="user-mention" data-user-id="262810">@Chris Simpkins</span>  I don't think <code>mdbook</code> ever deals with the server, thus the cache. It probably is the GitHub server realm, which I think should be OK with proper caching</p>



<a name="189538995"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189538995" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189538995">(Mar 02 2020 at 21:29)</a>:</h4>
<p><span class="user-mention" data-user-id="262810">@Chris Simpkins</span> Heh... <a href="https://crates.io/crates/mdbook-graphviz" target="_blank" title="https://crates.io/crates/mdbook-graphviz">https://crates.io/crates/mdbook-graphviz</a></p>



<a name="189539283"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189539283" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189539283">(Mar 02 2020 at 21:31)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> Ah! Very nice.  So we wouldn't need a separate build process for images.  We can just use the code in the hackmd Markdown source.  That would be ideal.  I believe that the only non-graphviz default is the typeface that is used for the nodes at the moment.  We would just need to choose one that is supported in the env where the build occurs.</p>



<a name="189539353"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189539353" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189539353">(Mar 02 2020 at 21:32)</a>:</h4>
<p>I would not worry about browser image caches</p>



<a name="189539389"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189539389" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189539389">(Mar 02 2020 at 21:32)</a>:</h4>
<p>(though I have no idea if our caching headers are good enough in practice)</p>



<a name="189539561"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189539561" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189539561">(Mar 02 2020 at 21:34)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Thoughts about an automated build approach for new diagram img files in the Rustc Guide?  We are pulling together graphviz .dot source files to support it in <a href="https://hackmd.io/24S8FCKTS2mp8zVOdrDjww" target="_blank" title="https://hackmd.io/24S8FCKTS2mp8zVOdrDjww">https://hackmd.io/24S8FCKTS2mp8zVOdrDjww</a>.  <span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> and I are interested in whether it would be appropriate to commit these img sources to the repository and create an automated img build approach with them as part of the existing GH Action static site build pipeline</p>



<a name="189539789"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189539789" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189539789">(Mar 02 2020 at 21:37)</a>:</h4>
<p>I would prefer the raw sources, though we should avoid if possible a mandatory dependency on non-rust tools (e.g. graphviz) to avoid making contribution on (especially) non Linux platforms harder</p>



<a name="189539887"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189539887" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189539887">(Mar 02 2020 at 21:38)</a>:</h4>
<p>Requiring graphviz or whatever to edit the raw sources is fine though - we may want to commit both the inputs and outputs if that's the case</p>



<a name="189539926"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189539926" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189539926">(Mar 02 2020 at 21:39)</a>:</h4>
<p>That seems to argue for support via CI/CD?  Contributors could just edit the graphviz source files and push for updates?</p>



<a name="189539936"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189539936" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189539936">(Mar 02 2020 at 21:39)</a>:</h4>
<p>So committing both the raw <code>.dot</code> and the output <code>.svg</code> or <code>.jpg</code> or whatever</p>



<a name="189539954"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189539954" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189539954">(Mar 02 2020 at 21:39)</a>:</h4>
<p><span class="user-mention silent" data-user-id="262810">Chris Simpkins</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-learning/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams/near/189539926" title="#narrow/stream/196385-t-compiler.2Fwg-learning/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams/near/189539926">said</a>:</p>
<blockquote>
<p>That seems to argue for support via CI/CD?  Contributors could just edit the graphviz source files and push for updates?</p>
</blockquote>
<p>You mean, automatically added in a PR?</p>



<a name="189540154"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189540154" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189540154">(Mar 02 2020 at 21:42)</a>:</h4>
<p>Platforms without graphviz availability might have more difficulty generating <em>new</em> images  or editing existing ones if they are reasonably detailed and require img views before a commit (though there are tools like <a href="https://sketchviz.com/" target="_blank" title="https://sketchviz.com/">https://sketchviz.com/</a> and hackmd available as web apps to support views of graphviz sources). The build happens in the CD pipeline and is not tied to a local graphviz dependency.</p>



<a name="189543559"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189543559" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189543559">(Mar 02 2020 at 22:15)</a>:</h4>
<p><span class="user-mention" data-user-id="262810">@Chris Simpkins</span> Maybe add those concerns to the proposal HackMD?</p>



<a name="189548732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189548732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189548732">(Mar 02 2020 at 23:29)</a>:</h4>
<p>I'm a bit torn. I don't like committing artifacts, but I agree that we should not make graphviz mandatory to contribute...</p>



<a name="189548753"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189548753" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189548753">(Mar 02 2020 at 23:29)</a>:</h4>
<p>Regarding the technical aspects, the .travis.yml can be used to invoke a post-test-success script before Travis pushes artifacts to gh pages</p>



<a name="189563433"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal%3A%20New%20Rustc%20Guide%20Diagrams/near/189563433" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chris Simpkins <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams.html#189563433">(Mar 03 2020 at 04:51)</a>:</h4>
<p><span class="user-mention silent" data-user-id="255061">LeSeulArtichaut</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-learning/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams/near/189543559" title="#narrow/stream/196385-t-compiler.2Fwg-learning/topic/Proposal.3A.20New.20Rustc.20Guide.20Diagrams/near/189543559">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="262810">Chris Simpkins</span> Maybe add those concerns to the proposal HackMD?</p>
</blockquote>
<p>Added to this section <a href="https://hackmd.io/24S8FCKTS2mp8zVOdrDjww?both#Potential-Issues-with-this-Approach" target="_blank" title="https://hackmd.io/24S8FCKTS2mp8zVOdrDjww?both#Potential-Issues-with-this-Approach">https://hackmd.io/24S8FCKTS2mp8zVOdrDjww?both#Potential-Issues-with-this-Approach</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>